Submission E-mails' Heading Levels#170
Open
Scullyon wants to merge 2 commits intofeat/DF-555-fix-package-imports-consumer-fixesfrom
Open
Submission E-mails' Heading Levels#170Scullyon wants to merge 2 commits intofeat/DF-555-fix-package-imports-consumer-fixesfrom
Scullyon wants to merge 2 commits intofeat/DF-555-fix-package-imports-consumer-fixesfrom
Conversation
alexluckett
changed the base branch from
main
to
feat/DF-555-fix-package-imports-consumer-fixes
alexluckett
reviewed
Apr 29, 2026
Contributor
alexluckett
left a comment
alexluckett
left a comment
There was a problem hiding this comment.
I don't think the nullables are intended, are they? Null is the default value but it's not valid, I expect an error on startup if they're not set.
| oidcJwksUri: { | ||
| doc: 'The URI that defines the OIDC json web key set', | ||
| format: String, | ||
| nullable: true, |
Contributor
There was a problem hiding this comment.
I don't think the nullables are intended, are they? Null is the default value but it's not valid, I expect an error on startup if they're not set.
Contributor
Author
There was a problem hiding this comment.
This shouldn't be there. Good spot, thanks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the heading levels in the first section of the e-mail that goes to the form submitted to be H2 (in the e-mail, which is H1 in the template).
Note: this PR includes the changes in this PR which should be approved and merged first.